Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable Centos 7 on s390x architecture #622

Closed
wants to merge 1 commit into from
Closed

feat: disable Centos 7 on s390x architecture #622

wants to merge 1 commit into from

Conversation

nestoracunablanco
Copy link
Contributor

This commit disables the generation of templates for the s390x architecture, as there are no references to CentOS 7 in the osinfo-db for this architecture.

What this PR does / why we need it: s390x enablement

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 16, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 16, 2024

Hi @nestoracunablanco. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nestoracunablanco
feat: disable Centos 7 on s390x architecture
9010a09 
This commit disables the generation of templates for the s390x
architecture, as there are no references to CentOS 7 in the
osinfo-db for this architecture.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 16, 2024
@ksimon1
Copy link
Member

ksimon1 commented Oct 16, 2024

@nestoracunablanco FYI #621

@nestoracunablanco
Copy link
Contributor Author

@ksimon1, thank you for the information. I will keep this PR on hold until #621 is approved or merged.

@nestoracunablanco
Copy link
Contributor Author

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024
@nestoracunablanco nestoracunablanco deleted the fix/disableCentos7s390x branch October 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix Awaiting requested review from 0xFelix

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nestoracunablanco @kubevirt-bot @ksimon1